diff options
| author |   Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2019-06-12 12:03:43 +0100 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-06-12 13:56:06 +0100 |
| commit | db057679de3e9e6a03c1bcd5aee09b0d25fd9f5b (patch) | |
| tree | b24361811dab99bf04b8c16f9f153dac6ac6bf5a /drivers/base/regmap/regmap.c | |
| parent | regmap: debugfs: Fix memory leak in regmap_debugfs_init (diff) | |
| download | linux-dev-db057679de3e9e6a03c1bcd5aee09b0d25fd9f5b.tar.xz linux-dev-db057679de3e9e6a03c1bcd5aee09b0d25fd9f5b.zip | |
regmap: fix bulk writes on paged registers
On buses like SlimBus and SoundWire which does not support
gather_writes yet in regmap, A bulk write on paged register
would be silently ignored after programming page.
This is because local variable 'ret' value in regmap_raw_write_impl()
gets reset to 0 once page register is written successfully and the
code below checks for 'ret' value to be -ENOTSUPP before linearising
the write buffer to send to bus->write().
Fix this by resetting the 'ret' value to -ENOTSUPP in cases where
gather_writes() is not supported or single register write is
not possible.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base/regmap/regmap.c')
| -rw-r--r-- | drivers/base/regmap/regmap.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index f1025452bb39..19f57ccfbe1d 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1637,6 +1637,8 @@ static int _regmap_raw_write_impl(struct regmap *map, unsigned int reg, map->format.reg_bytes + map->format.pad_bytes, val, val_len); + else + ret = -ENOTSUPP; /* If that didn't work fall back on linearising by hand. */ if (ret == -ENOTSUPP) { |