diff options
| author |   Mark Brown <broonie@kernel.org> | 2022-06-22 18:17:23 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-06-27 13:21:59 +0100 |
| commit | 3d0afe9cf1ef871a71596f990d7d2e60cc0b8669 (patch) | |
| tree | 529e0cb243def9fab64de48f051c94142df20e14 /drivers/base/regmap | |
| parent | Merge tag 'regmap-field-bit-helpers' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap into regmap-5.20 (diff) | |
| download | linux-dev-3d0afe9cf1ef871a71596f990d7d2e60cc0b8669.tar.xz linux-dev-3d0afe9cf1ef871a71596f990d7d2e60cc0b8669.zip | |
regmap: Don't warn about cache only mode for devices with no cache
For devices with no cache it can make sense to use cache only mode as a
mechanism for trapping writes to hardware which is inaccessible but since
no cache is equivalent to cache bypass we force such devices into bypass
mode. This means that our check that bypass and cache only mode aren't both
enabled simultanously is less sensible for devices without a cache so relax
it.
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220622171723.1235749-1-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base/regmap')
| -rw-r--r-- | drivers/base/regmap/regcache.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 2eaffd3224c9..ef62ec225d81 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -495,7 +495,8 @@ EXPORT_SYMBOL_GPL(regcache_drop_region); void regcache_cache_only(struct regmap *map, bool enable) { map->lock(map->lock_arg); - WARN_ON(map->cache_bypass && enable); + WARN_ON(map->cache_type != REGCACHE_NONE && + map->cache_bypass && enable); map->cache_only = enable; trace_regmap_cache_only(map, enable); map->unlock(map->lock_arg); |