diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-09-01 16:23:34 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-09-05 13:09:43 +0100 |
| commit | f78d5e1168e08429bc948d09b6dc11fec5e019f7 (patch) | |
| tree | fb9c2c019ad2317868f03c9e61d50823b2a59add /drivers/base/regmap | |
| parent | regmap: mmio: Fix rebase error (diff) | |
| download | linux-dev-f78d5e1168e08429bc948d09b6dc11fec5e019f7.tar.xz linux-dev-f78d5e1168e08429bc948d09b6dc11fec5e019f7.zip | |
regmap: trace: Remove useless check for NULL for bulk ops
If the buffer pointer is NULL we already are in troubles since
regmap bulk API expects caller to provide valid parameters,
it dereferences that without any checks before we call for
traces.
Moreover, the current code will print garbage in the case of
buffer is NULL and length is not 0.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220901132336.33234-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base/regmap')
| -rw-r--r-- | drivers/base/regmap/trace.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h index 04329ba68ec5..e92edc4f4ca5 100644 --- a/drivers/base/regmap/trace.h +++ b/drivers/base/regmap/trace.h @@ -82,8 +82,7 @@ DECLARE_EVENT_CLASS(regmap_bulk, __assign_str(name, regmap_name(map)); __entry->reg = reg; __entry->val_len = val_len; - if (val) - memcpy(__get_dynamic_array(buf), val, val_len); + memcpy(__get_dynamic_array(buf), val, val_len); ), TP_printk("%s reg=%x val=%s", __get_str(name), |