diff options
| author |   Ming Lei <tom.leiming@gmail.com> | 2009-07-11 11:11:10 +0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@suse.de> | 2009-07-28 13:45:22 -0700 |
| commit | 3b4418c67a70278964b063b5e1f56dcb3d0a41f3 (patch) | |
| tree | 4112e10d4d523a55bc95fdfc46306881f7569820 /drivers/base | |
| parent | sysfs: fix hardlink count on device_move (diff) | |
| download | linux-dev-3b4418c67a70278964b063b5e1f56dcb3d0a41f3.tar.xz linux-dev-3b4418c67a70278964b063b5e1f56dcb3d0a41f3.zip | |
driver core: firmware_class:fix memory leak of page pointers array
The page pointers array is allocated in fw_realloc_buffer() called by
firmware_data_write(), and should be freed in release function of firmware
device.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Reported-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/firmware_class.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index f285f441fab9..7376367bcb80 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -180,7 +180,6 @@ static ssize_t firmware_loading_store(struct device *dev, goto err; } /* Pages will be freed by vfree() */ - fw_priv->pages = NULL; fw_priv->page_array_size = 0; fw_priv->nr_pages = 0; complete(&fw_priv->completion); |