diff options
| author |   Matthew Wilcox <matthew.r.wilcox@intel.com> | 2014-06-04 16:07:50 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 16:54:02 -0700 |
| commit | 96f8d8e0965ba3d895f4cf63bbb16fd9fca8998b (patch) | |
| tree | 1c8423c21320beb5a499a7fcf891e8d4debef1c1 /drivers/block/brd.c | |
| parent | brd: add support for rw_page() (diff) | |
| download | linux-dev-96f8d8e0965ba3d895f4cf63bbb16fd9fca8998b.tar.xz linux-dev-96f8d8e0965ba3d895f4cf63bbb16fd9fca8998b.zip | |
brd: return -ENOSPC rather than -ENOMEM on page allocation failure
brd is effectively a thinly provisioned device. Thinly provisioned
devices return -ENOSPC when they can't write a new block. -ENOMEM is an
implementation detail that callers shouldn't know.
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Acked-by: Dave Chinner <david@fromorbit.com>
Cc: Dheeraj Reddy <dheeraj.reddy@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/block/brd.c')
| -rw-r--r-- | drivers/block/brd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 807d3d5d2fe5..c7d138eca731 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -200,11 +200,11 @@ static int copy_to_brd_setup(struct brd_device *brd, sector_t sector, size_t n) copy = min_t(size_t, n, PAGE_SIZE - offset); if (!brd_insert_page(brd, sector)) - return -ENOMEM; + return -ENOSPC; if (copy < n) { sector += copy >> SECTOR_SHIFT; if (!brd_insert_page(brd, sector)) - return -ENOMEM; + return -ENOSPC; } return 0; } @@ -384,7 +384,7 @@ static int brd_direct_access(struct block_device *bdev, sector_t sector, return -ERANGE; page = brd_insert_page(brd, sector); if (!page) - return -ENOMEM; + return -ENOSPC; *kaddr = page_address(page); *pfn = page_to_pfn(page); |