diff options
| author |   Yu Kuai <yukuai3@huawei.com> | 2021-09-16 17:33:46 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2021-10-18 14:50:37 -0600 |
| commit | fcf3d633d8e101e84a0e072ab79957b938ac7e06 (patch) | |
| tree | 0d88bf8b4ff410dfa31e98dbd9bec444232b622e /drivers/block/nbd.c | |
| parent | nbd: make sure request completion won't concurrent (diff) | |
| download | linux-dev-fcf3d633d8e101e84a0e072ab79957b938ac7e06.tar.xz linux-dev-fcf3d633d8e101e84a0e072ab79957b938ac7e06.zip | |
nbd: check sock index in nbd_read_stat()
The sock that clent send request in nbd_send_cmd() and receive reply
in nbd_read_stat() should be the same.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20210916093350.1410403-4-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block/nbd.c')
| -rw-r--r-- | drivers/block/nbd.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 0bb3c1e2d575..49c501cf8a8b 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -751,6 +751,10 @@ static struct nbd_cmd *nbd_read_stat(struct nbd_device *nbd, int index) ret = -ENOENT; goto out; } + if (cmd->index != index) { + dev_err(disk_to_dev(nbd->disk), "Unexpected reply %d from different sock %d (expected %d)", + tag, index, cmd->index); + } if (cmd->cmd_cookie != nbd_handle_to_cookie(handle)) { dev_err(disk_to_dev(nbd->disk), "Double reply on req %p, cmd_cookie %u, handle cookie %u\n", req, cmd->cmd_cookie, nbd_handle_to_cookie(handle)); |