diff options
| author |   NeilBrown <neilb@suse.com> | 2017-06-18 14:38:57 +1000 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2017-06-18 12:40:59 -0600 |
| commit | 011067b05668b05aae88e5a24cff0ca0a67ca0b0 (patch) | |
| tree | b56fb4114e8bd71ffd36520f1b4cf7e4e49f1c79 /drivers/block | |
| parent | blk: remove bio_set arg from blk_queue_split() (diff) | |
| download | linux-dev-011067b05668b05aae88e5a24cff0ca0a67ca0b0.tar.xz linux-dev-011067b05668b05aae88e5a24cff0ca0a67ca0b0.zip | |
blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
"flags" arguments are often seen as good API design as they allow
easy extensibility.
bioset_create_nobvec() is implemented internally as a variation in
flags passed to __bioset_create().
To support future extension, make the internal structure part of the
API.
i.e. add a 'flags' argument to bioset_create() and discard
bioset_create_nobvec().
Note that the bio_split allocations in drivers/md/raid* do not need
the bvec mempool - they should have used bioset_create_nobvec().
Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/drbd/drbd_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 84455c365f57..b395fe391171 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -2165,7 +2165,7 @@ static int drbd_create_mempools(void) goto Enomem; /* mempools */ - drbd_md_io_bio_set = bioset_create(DRBD_MIN_POOL_PAGES, 0); + drbd_md_io_bio_set = bioset_create(DRBD_MIN_POOL_PAGES, 0, BIOSET_NEED_BVECS); if (drbd_md_io_bio_set == NULL) goto Enomem; |