diff options
| author |   Tomas Bortoli <tomasbortoli@gmail.com> | 2019-05-28 15:42:58 +0200 |
|---|---|---|
| committer |   Marcel Holtmann <marcel@holtmann.org> | 2019-07-06 13:02:38 +0200 |
| commit | 4ce9146e0370fcd573f0372d9b4e5a211112567c (patch) | |
| tree | fad9d7e56c2f80cf1fd74eeff93c7f2ad20f8be8 /drivers/bluetooth | |
| parent | Bluetooth:: btrtl: Add support for RTL8723DU (diff) | |
| download | linux-dev-4ce9146e0370fcd573f0372d9b4e5a211112567c.tar.xz linux-dev-4ce9146e0370fcd573f0372d9b4e5a211112567c.zip | |
Bluetooth: hci_bcsp: Fix memory leak in rx_skb
Syzkaller found that it is possible to provoke a memory leak by
never freeing rx_skb in struct bcsp_struct.
Fix by freeing in bcsp_close()
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
| -rw-r--r-- | drivers/bluetooth/hci_bcsp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 82b13faa9422..fe2e307009f4 100644 --- a/drivers/bluetooth/hci_bcsp.c +++ b/drivers/bluetooth/hci_bcsp.c @@ -744,6 +744,11 @@ static int bcsp_close(struct hci_uart *hu) skb_queue_purge(&bcsp->rel); skb_queue_purge(&bcsp->unrel); + if (bcsp->rx_skb) { + kfree_skb(bcsp->rx_skb); + bcsp->rx_skb = NULL; + } + kfree(bcsp); return 0; } |