diff options
| author |   Martin Schwidefsky <schwidefsky@de.ibm.com> | 2015-07-24 13:13:30 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2015-07-28 14:59:54 +0800 |
| commit | 17fb874dee093139923af8ed36061faa92cc8e79 (patch) | |
| tree | f2f58fa3ba55fc20a5b6c786e2d32ad62046ce45 /drivers/char/hw_random | |
| parent | crypto: ixp4xx - Remove bogus BUG_ON on scattered dst buffer (diff) | |
| download | linux-dev-17fb874dee093139923af8ed36061faa92cc8e79.tar.xz linux-dev-17fb874dee093139923af8ed36061faa92cc8e79.zip | |
hwrng: core - correct error check of kthread_run call
The kthread_run() function can return two different error values
but the hwrng core only checks for -ENOMEM. If the other error
value -EINTR is returned it is assigned to hwrng_fill and later
used on a kthread_stop() call which naturally crashes.
Cc: stable@vger.kernel.org
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char/hw_random')
| -rw-r--r-- | drivers/char/hw_random/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index da8faf78536a..5643b65cee20 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -429,7 +429,7 @@ static int hwrng_fillfn(void *unused) static void start_khwrngd(void) { hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng"); - if (hwrng_fill == ERR_PTR(-ENOMEM)) { + if (IS_ERR(hwrng_fill)) { pr_err("hwrng_fill thread creation failed"); hwrng_fill = NULL; } |