diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-04-06 17:21:44 +0100 |
|---|---|---|
| committer |   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2018-05-09 14:45:46 +0300 |
| commit | f20b4f2245367e7471d844fb8685fd46f15c17db (patch) | |
| tree | b530e62a3bfb0221358613dc5dee27c292936127 /drivers/char/tpm/st33zp24/st33zp24.c | |
| parent | tpm: move the delay_msec increment after sleep in tpm_transmit() (diff) | |
| download | linux-dev-f20b4f2245367e7471d844fb8685fd46f15c17db.tar.xz linux-dev-f20b4f2245367e7471d844fb8685fd46f15c17db.zip | |
tpm: st33zp24: remove redundant null check on chip
Currently chip is being dereferenced by the call to dev_get_drvdata
before it is being null checked, however, chip can never be null, so
this check is misleading and redundant. Remove it.
Detected by CoverityScan, CID#1357806 ("Dereference before null check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
Diffstat (limited to 'drivers/char/tpm/st33zp24/st33zp24.c')
| -rw-r--r-- | drivers/char/tpm/st33zp24/st33zp24.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index f95b9c75175b..abd675bec88c 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf, int ret; u8 data; - if (!chip) - return -EBUSY; if (len < TPM_HEADER_SIZE) return -EBUSY; |