diff options
| author |   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2018-09-03 04:01:26 +0300 |
|---|---|---|
| committer | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2018-10-05 13:47:33 +0300 |
| commit | 84b59f6487d82d3ab4247a099aba66d4d17e8b08 (patch) | |
| tree | a028dd73b36a47922eb1867bd6ca95bf0da6a784 /drivers/char/tpm/tpm2-cmd.c | |
| parent | keys: Fix the use of the C++ keyword "private" in uapi/linux/keyctl.h (diff) | |
| download | linux-dev-84b59f6487d82d3ab4247a099aba66d4d17e8b08.tar.xz linux-dev-84b59f6487d82d3ab4247a099aba66d4d17e8b08.zip | |
tpm: fix response size validation in tpm_get_random()
When checking whether the response is large enough to be able to contain
the received random bytes in tpm_get_random() and tpm2_get_random(),
they fail to take account the header size, which should be added to the
minimum size. This commit fixes this issue.
Cc: stable@vger.kernel.org
Fixes: c659af78eb7b ("tpm: Check size of response before accessing data")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Diffstat (limited to 'drivers/char/tpm/tpm2-cmd.c')
| -rw-r--r-- | drivers/char/tpm/tpm2-cmd.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c index c31b490bd41d..3acf4fd4e5a5 100644 --- a/drivers/char/tpm/tpm2-cmd.c +++ b/drivers/char/tpm/tpm2-cmd.c @@ -329,7 +329,9 @@ int tpm2_get_random(struct tpm_chip *chip, u8 *dest, size_t max) &buf.data[TPM_HEADER_SIZE]; recd = min_t(u32, be16_to_cpu(out->size), num_bytes); if (tpm_buf_length(&buf) < - offsetof(struct tpm2_get_random_out, buffer) + recd) { + TPM_HEADER_SIZE + + offsetof(struct tpm2_get_random_out, buffer) + + recd) { err = -EFAULT; goto out; } |