diff options
| author |   Corey Minyard <cminyard@mvista.com> | 2018-06-21 15:32:48 -0500 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2018-09-18 16:15:33 -0500 |
| commit | 1574608f5f4204440d6d9f52b971aba967664764 (patch) | |
| tree | ec1b4b23194da5a6cd854302d465e3dbdaf98990 /drivers/char | |
| parent | ipmi:dmi: Use pr_fmt in the IPMI DMI code (diff) | |
| download | linux-dev-1574608f5f4204440d6d9f52b971aba967664764.tar.xz linux-dev-1574608f5f4204440d6d9f52b971aba967664764.zip | |
ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address
Looking at logs from systems all over the place, it looks like tons
of broken systems exist that set the base address to zero. I can
only guess that is some sort of non-standard idea to mark the
interface as not being present. It can't be zero, anyway, so just
complain and ignore it.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_dmi.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c index 736ebbbc2fcd..8e0c78696c70 100644 --- a/drivers/char/ipmi/ipmi_dmi.c +++ b/drivers/char/ipmi/ipmi_dmi.c @@ -218,6 +218,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) slave_addr = data[DMI_IPMI_SLAVEADDR]; memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); + if (!base_addr) { + pr_err("Base address is zero, assuming no IPMI interface\n"); + return; + } if (len >= DMI_IPMI_VER2_LENGTH) { if (type == IPMI_DMI_TYPE_SSIF) { offset = 0; |