diff options
| author |   Xiu Jianfeng <xiujianfeng@huawei.com> | 2022-03-18 14:02:01 +0800 |
|---|---|---|
| committer |   Jarkko Sakkinen <jarkko@kernel.org> | 2022-05-23 18:47:49 +0300 |
| commit | d0dc1a7100f19121f6e7450f9cdda11926aa3838 (patch) | |
| tree | af5bf4c6e7066ae8884942a00426f2ffa2d0ac4c /drivers/char | |
| parent | tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool functions (diff) | |
| download | linux-dev-d0dc1a7100f19121f6e7450f9cdda11926aa3838.tar.xz linux-dev-d0dc1a7100f19121f6e7450f9cdda11926aa3838.zip | |
tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
Currently it returns zero when CRQ response timed out, it should return
an error code instead.
Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/tpm/tpm_ibmvtpm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c index 3af4c07a9342..d3989b257f42 100644 --- a/drivers/char/tpm/tpm_ibmvtpm.c +++ b/drivers/char/tpm/tpm_ibmvtpm.c @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, if (!wait_event_timeout(ibmvtpm->crq_queue.wq, ibmvtpm->rtce_buf != NULL, HZ)) { + rc = -ENODEV; dev_err(dev, "CRQ response timed out\n"); goto init_irq_cleanup; } |