diff options
| author |   Robert Hancock <robert.hancock@calian.com> | 2022-01-12 14:38:16 -0600 |
|---|---|---|
| committer |   Stephen Boyd <sboyd@kernel.org> | 2022-01-13 13:20:54 -0800 |
| commit | 49a8f2bc8d88702783c7e163ec84374e9a022f71 (patch) | |
| tree | 22d34841f83737f4f4e12a2ad8e1a30fb1846134 /drivers/clk/clk-si5341.c | |
| parent | Merge branches 'clk-ingenic' and 'clk-mediatek' into clk-next (diff) | |
| download | linux-dev-49a8f2bc8d88702783c7e163ec84374e9a022f71.tar.xz linux-dev-49a8f2bc8d88702783c7e163ec84374e9a022f71.zip | |
clk: si5341: Fix clock HW provider cleanup
The call to of_clk_add_hw_provider was not undone on remove or on probe
failure, which could cause an oops on a subsequent attempt to retrieve
clocks for the removed device. Switch to the devm version of the
function to avoid this issue.
Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver")
Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Link: https://lore.kernel.org/r/20220112203816.1784610-1-robert.hancock@calian.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/clk-si5341.c')
| -rw-r--r-- | drivers/clk/clk-si5341.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 57ae183982d8..f7b41366666e 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -1740,7 +1740,7 @@ static int si5341_probe(struct i2c_client *client, clk_prepare(data->clk[i].hw.clk); } - err = of_clk_add_hw_provider(client->dev.of_node, of_clk_si5341_get, + err = devm_of_clk_add_hw_provider(&client->dev, of_clk_si5341_get, data); if (err) { dev_err(&client->dev, "unable to add clk provider\n"); |