diff options
| author |   Ansuel Smith <ansuelsmth@gmail.com> | 2022-04-30 07:44:56 +0200 |
|---|---|---|
| committer |   Bjorn Andersson <bjorn.andersson@linaro.org> | 2022-06-27 15:41:37 -0500 |
| commit | fcfbfe373d41b4728ffec075f8f91b6572a88c27 (patch) | |
| tree | d26816deaa61acf78e13f6b6f980db46f2cdf076 /drivers/clk/qcom/clk-hfpll.c | |
| parent | clk: qcom: gcc-sm6350: Drop extra semicolon (diff) | |
| download | linux-dev-fcfbfe373d41b4728ffec075f8f91b6572a88c27.tar.xz linux-dev-fcfbfe373d41b4728ffec075f8f91b6572a88c27.zip | |
clk: qcom: clk-hfpll: use poll_timeout macro
Use regmap_read_poll_timeout macro instead of do-while structure to tidy
things up. Also set a timeout to prevent any sort of system stall.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220430054458.31321-2-ansuelsmth@gmail.com
Diffstat (limited to 'drivers/clk/qcom/clk-hfpll.c')
| -rw-r--r-- | drivers/clk/qcom/clk-hfpll.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/drivers/clk/qcom/clk-hfpll.c b/drivers/clk/qcom/clk-hfpll.c index e847d586a73a..7dd17c184b69 100644 --- a/drivers/clk/qcom/clk-hfpll.c +++ b/drivers/clk/qcom/clk-hfpll.c @@ -72,13 +72,16 @@ static void __clk_hfpll_enable(struct clk_hw *hw) regmap_update_bits(regmap, hd->mode_reg, PLL_RESET_N, PLL_RESET_N); /* Wait for PLL to lock. */ - if (hd->status_reg) { - do { - regmap_read(regmap, hd->status_reg, &val); - } while (!(val & BIT(hd->lock_bit))); - } else { + if (hd->status_reg) + /* + * Busy wait. Should never timeout, we add a timeout to + * prevent any sort of stall. + */ + regmap_read_poll_timeout(regmap, hd->status_reg, val, + !(val & BIT(hd->lock_bit)), 0, + 100 * USEC_PER_MSEC); + else udelay(60); - } /* Enable PLL output. */ regmap_update_bits(regmap, hd->mode_reg, PLL_OUTCTRL, PLL_OUTCTRL); |