diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-04 22:01:51 +0530 |
|---|---|---|
| committer |   Stephen Boyd <sboyd@kernel.org> | 2019-08-07 15:26:32 -0700 |
| commit | d432d04560301c6350158dc4a7e8275b331fd480 (patch) | |
| tree | 744cdff49922927abf22dea961f9704f7e76f5da /drivers/clk/st | |
| parent | clk: davinci: pll: Add of_node_put() in of_davinci_pll_init() (diff) | |
| download | linux-dev-d432d04560301c6350158dc4a7e8275b331fd480.tar.xz linux-dev-d432d04560301c6350158dc4a7e8275b331fd480.zip | |
clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()
In function st_of_flexgen_setup, variable pnode takes the return value
of of_get_parent, which gets a node but does not put it. If pnode is not
put before the function returns, it may cause a memory leak. Hence put
pnode after its last occurrence.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lkml.kernel.org/r/20190804163151.6511-1-nishkadg.linux@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/st')
| -rw-r--r-- | drivers/clk/st/clk-flexgen.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c index d18e49b4976f..4413b6e04a8e 100644 --- a/drivers/clk/st/clk-flexgen.c +++ b/drivers/clk/st/clk-flexgen.c @@ -326,6 +326,7 @@ static void __init st_of_flexgen_setup(struct device_node *np) return; reg = of_iomap(pnode, 0); + of_node_put(pnode); if (!reg) return; |