diff options
| author |   Maxime Ripard <maxime.ripard@free-electrons.com> | 2015-05-02 17:03:25 +0200 |
|---|---|---|
| committer |   Thomas Gleixner <tglx@linutronix.de> | 2015-05-05 10:35:58 +0200 |
| commit | 9fa8cc0a85c774b75218ba5f385792be387c190b (patch) | |
| tree | 3f72e674863c1e63531b9d9a1f2764a650a26255 /drivers/clocksource/timer-sun5i.c | |
| parent | clocksource: integrator: Fix of_io_request_and_map error check (diff) | |
| download | linux-dev-9fa8cc0a85c774b75218ba5f385792be387c190b.tar.xz linux-dev-9fa8cc0a85c774b75218ba5f385792be387c190b.zip | |
clocksource: sun5i: Fix of_io_request_and_map error check
of_io_request_and map returns an error pointer, but the current code assumes
that on error the returned pointer will be NULL.
Obviously, that makes the check completely useless. Change the test to actually
check for the proper error code.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/clocksource/timer-sun5i.c')
| -rw-r--r-- | drivers/clocksource/timer-sun5i.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c index 28aa4b7bb602..0ffb4ea7c925 100644 --- a/drivers/clocksource/timer-sun5i.c +++ b/drivers/clocksource/timer-sun5i.c @@ -324,7 +324,7 @@ static void __init sun5i_timer_init(struct device_node *node) int irq; timer_base = of_io_request_and_map(node, 0, of_node_full_name(node)); - if (!timer_base) + if (IS_ERR(timer_base)) panic("Can't map registers"); irq = irq_of_parse_and_map(node, 0); |