diff options
| author |   Viresh Kumar <viresh.kumar@linaro.org> | 2017-04-25 15:57:14 +0530 |
|---|---|---|
| committer |   Eduardo Valentin <edubezval@gmail.com> | 2017-05-27 17:32:24 -0700 |
| commit | 4d753aa7b6279e4b7d338947a434689962f430d1 (patch) | |
| tree | 07114a3ef8781b49b4254df85c3ca83e60c165f6 /drivers/cpufreq/qoriq-cpufreq.c | |
| parent | thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state() (diff) | |
| download | linux-dev-4d753aa7b6279e4b7d338947a434689962f430d1.tar.xz linux-dev-4d753aa7b6279e4b7d338947a434689962f430d1.zip | |
thermal: cpu_cooling: use cpufreq_policy to register cooling device
The CPU cooling driver uses the cpufreq policy, to get clip_cpus, the
frequency table, etc. Most of the callers of CPU cooling driver's
registration routines have the cpufreq policy with them, but they only
pass the policy->related_cpus cpumask. The __cpufreq_cooling_register()
routine then gets the policy by itself and uses it.
It would be much better if the callers can pass the policy instead
directly. This also fixes a basic design flaw, where the policy can be
freed while the CPU cooling driver is still active.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/cpufreq/qoriq-cpufreq.c')
| -rw-r--r-- | drivers/cpufreq/qoriq-cpufreq.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index e2ea433a5f9c..4ada55b8856e 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -278,8 +278,7 @@ static void qoriq_cpufreq_ready(struct cpufreq_policy *policy) struct device_node *np = of_get_cpu_node(policy->cpu, NULL); if (of_find_property(np, "#cooling-cells", NULL)) { - cpud->cdev = of_cpufreq_cooling_register(np, - policy->related_cpus); + cpud->cdev = of_cpufreq_cooling_register(np, policy); if (IS_ERR(cpud->cdev) && PTR_ERR(cpud->cdev) != -ENOSYS) { pr_err("cpu%d is not running as cooling device: %ld\n", |