aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/cpuidle
diff options
context:
space:
mode:
authorJoao Martins <joao.m.martins@oracle.com>2019-09-08 00:45:24 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2019-09-11 17:36:30 +0200
commit472f263660832b90e53bede2020f68cd14f8b76c (patch)
tree77bf960be9ffac5d80c2e23bdb2bfb278579b74d /drivers/cpuidle
parentcpuidle-haltpoll: return -ENODEV on modinit failure (diff)
downloadlinux-dev-472f263660832b90e53bede2020f68cd14f8b76c.tar.xz
linux-dev-472f263660832b90e53bede2020f68cd14f8b76c.zip
cpuidle-haltpoll: do not set an owner to allow modunload
cpuidle-haltpoll can be built as a module to allow optional late load. Given we are setting @owner to THIS_MODULE, cpuidle will attempt to grab a module reference every time a cpuidle_device is registered -- so essentially all online cpus get a reference. This prevents for the module to be unloaded later, which makes the module_exit callback entirely unused. Thus remove the @owner and allow module to be unloaded. Fixes: fa86ee90eb11 ("add cpuidle-haltpoll driver") Signed-off-by: Joao Martins <joao.m.martins@oracle.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpuidle')
-rw-r--r--drivers/cpuidle/cpuidle-haltpoll.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
index 7a0239ef717e..49a65c6fe91e 100644
--- a/drivers/cpuidle/cpuidle-haltpoll.c
+++ b/drivers/cpuidle/cpuidle-haltpoll.c
@@ -35,7 +35,6 @@ static int default_enter_idle(struct cpuidle_device *dev,
static struct cpuidle_driver haltpoll_driver = {
.name = "haltpoll",
.governor = "haltpoll",
- .owner = THIS_MODULE,
.states = {
{ /* entry 0 is for polling */ },
{