diff options
| author |   Tudor-Dan Ambarus <tudor.ambarus@microchip.com> | 2018-03-23 12:42:21 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2018-03-31 01:33:12 +0800 |
| commit | 0e7da29d6c31f897c544c1f7499389111225566f (patch) | |
| tree | 0fce048b25e77abf91688dd3e6191d43ef1e6664 /drivers/crypto | |
| parent | crypto: chelsio - don't leak pointers to authenc keys (diff) | |
| download | linux-dev-0e7da29d6c31f897c544c1f7499389111225566f.tar.xz linux-dev-0e7da29d6c31f897c544c1f7499389111225566f.zip | |
crypto: ixp4xx - don't leak pointers to authenc keys
In ixp4xx's aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/ixp4xx_crypto.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c index 717a26607bdb..27f7dad2d45d 100644 --- a/drivers/crypto/ixp4xx_crypto.c +++ b/drivers/crypto/ixp4xx_crypto.c @@ -1167,9 +1167,11 @@ static int aead_setkey(struct crypto_aead *tfm, const u8 *key, ctx->authkey_len = keys.authkeylen; ctx->enckey_len = keys.enckeylen; + memzero_explicit(&keys, sizeof(keys)); return aead_setup(tfm, crypto_aead_authsize(tfm)); badkey: crypto_aead_set_flags(tfm, CRYPTO_TFM_RES_BAD_KEY_LEN); + memzero_explicit(&keys, sizeof(keys)); return -EINVAL; } |