diff options
| author |   Tony Lindgren <tony@atomide.com> | 2021-07-27 13:23:39 +0300 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2021-08-06 19:45:24 +0800 |
| commit | 1dd0d7fe4b7a50f3a9580e994060e8a8a1c3263e (patch) | |
| tree | 9464cd167792aa904f88b618853cab5618a0fc49 /drivers/crypto | |
| parent | crypto: omap-sham - drop suspend and resume functions (diff) | |
| download | linux-dev-1dd0d7fe4b7a50f3a9580e994060e8a8a1c3263e.tar.xz linux-dev-1dd0d7fe4b7a50f3a9580e994060e8a8a1c3263e.zip | |
crypto: omap-sham - drop pm_runtime_irqsafe() usage
Commit b0a3d8986a76 ("crypto: omap-sham - Use pm_runtime_irq_safe()") added
the use of pm_runtime_irq_safe() as pm_runtime_get_sync() was called
from a tasklet.
We now use the crypto engine queue instead of a custom queue since
commit 33c3d434d91 ("crypto: omap-sham - convert to use crypto engine").
We want to drop the use of pm_runtime_irq_safe() in general as it takes a
permanent usage count on the parent device causing issues for power
management.
Based on testing with CONFIG_DEBUG_ATOMIC_SLEEP=y, modprobe omap-sham,
followed by modprobe tcrypt sec=1 mode=423, I have not been able to
reproduce the scheduling while atomic issue seen earlier with current
kernels and we can just drop the call to pm_runtime_irq_safe().
Cc: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/omap-sham.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 04c1b7b4d18a..735abd8f68d6 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sham.c @@ -2113,7 +2113,6 @@ static int omap_sham_probe(struct platform_device *pdev) dd->fallback_sz = OMAP_SHA_DMA_THRESHOLD; pm_runtime_enable(dev); - pm_runtime_irq_safe(dev); err = pm_runtime_get_sync(dev); if (err < 0) { |