diff options
| author |   YueHaibing <yuehaibing@huawei.com> | 2022-09-20 11:21:18 +0800 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2022-09-30 13:57:50 +0800 |
| commit | 70513e1d65599f39aba4fa6594546f7c81fa59f4 (patch) | |
| tree | 2f4d1f524cc66d2c5498ccc5908ec846e9e78be3 /drivers/crypto | |
| parent | crypto: virtio - fix memory-leak (diff) | |
| download | linux-dev-70513e1d65599f39aba4fa6594546f7c81fa59f4.tar.xz linux-dev-70513e1d65599f39aba4fa6594546f7c81fa59f4.zip | |
crypto: aspeed - Fix check for platform_get_irq() errors
The platform_get_irq() function returns negative on error and
positive non-zero values on success. It never returns zero, but if it
did then treat that as a success.
Also remove redundant dev_err() print as platform_get_irq() already
prints an error.
Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/aspeed/aspeed-hace.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c index 3f880aafb6a2..f7f1d33defb1 100644 --- a/drivers/crypto/aspeed/aspeed-hace.c +++ b/drivers/crypto/aspeed/aspeed-hace.c @@ -130,10 +130,8 @@ static int aspeed_hace_probe(struct platform_device *pdev) /* Get irq number and register it */ hace_dev->irq = platform_get_irq(pdev, 0); - if (!hace_dev->irq) { - dev_err(&pdev->dev, "Failed to get interrupt\n"); + if (hace_dev->irq < 0) return -ENXIO; - } rc = devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0, dev_name(&pdev->dev), hace_dev); |