diff options
| author |   Christian König <christian.koenig@amd.com> | 2020-09-14 15:09:33 +0200 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2020-11-19 10:36:36 +0100 |
| commit | 295992fb815e791d14b18ef7cdbbaf1a76211a31 (patch) | |
| tree | 2b72922a11a0abd63cb11969d3fd5cd7d2874e1c /drivers/dma-buf | |
| parent | mm: mmap: fix fput in error path v2 (diff) | |
| download | linux-dev-295992fb815e791d14b18ef7cdbbaf1a76211a31.tar.xz linux-dev-295992fb815e791d14b18ef7cdbbaf1a76211a31.zip | |
mm: introduce vma_set_file function v5
Add the new vma_set_file() function to allow changing
vma->vm_file with the necessary refcount dance.
v2: add more users of this.
v3: add missing EXPORT_SYMBOL, rebase on mmap cleanup,
add comments why we drop the reference on two occasions.
v4: make it clear that changing an anonymous vma is illegal.
v5: move vma_set_file to mm/util.c
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v2)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Link: https://patchwork.freedesktop.org/patch/399360/
Diffstat (limited to 'drivers/dma-buf')
| -rw-r--r-- | drivers/dma-buf/dma-buf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 282bd8b84170..e63684d4cd90 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -1183,8 +1183,7 @@ int dma_buf_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma, return -EINVAL; /* readjust the vma */ - fput(vma->vm_file); - vma->vm_file = get_file(dmabuf->file); + vma_set_file(vma, dmabuf->file); vma->vm_pgoff = pgoff; return dmabuf->ops->mmap(dmabuf, vma); |