diff options
| author |   Gustavo Pimentel <Gustavo.Pimentel@synopsys.com> | 2021-02-18 20:04:06 +0100 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-03-16 22:58:53 +0530 |
| commit | e970dcc4bd8e0a1376e794fc81d41d0fc98262dd (patch) | |
| tree | ecedeb62a7db0671cfc3a7704713c2dcf8714bc8 /drivers/dma/dw-edma/dw-edma-core.c | |
| parent | dmaengine: dw-edma: Move struct dentry variable from static definition into dw_edma struct (diff) | |
| download | linux-dev-e970dcc4bd8e0a1376e794fc81d41d0fc98262dd.tar.xz linux-dev-e970dcc4bd8e0a1376e794fc81d41d0fc98262dd.zip | |
dmaengine: dw-edma: Fix crash on loading/unloading driver
When the driver is compiled as a module and loaded if we try to unload
it, the Kernel shows a crash log. This Kernel crash is due to the
dma_async_device_unregister() call done after deleting the channels,
this patch fixes this issue.
Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/4aa850c035cf7ee488f1d3fb6dee0e37be0dce0a.1613674948.git.gustavo.pimentel@synopsys.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/dw-edma/dw-edma-core.c')
| -rw-r--r-- | drivers/dma/dw-edma/dw-edma-core.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index bc94c8dfd9fd..a26d0d578a27 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); |