diff options
| author |   Jarkko Nikula <jarkko.nikula@linux.intel.com> | 2015-03-10 11:37:24 +0200 |
|---|---|---|
| committer |   Vinod Koul <vinod.koul@intel.com> | 2015-03-16 22:11:06 +0530 |
| commit | b26072276f20ce93717fdad5210e4ae9f1c944fa (patch) | |
| tree | bcaddf54cf2f12cf57d4de4d8e17116166811411 /drivers/dma/dw | |
| parent | dmaengine: dw: Make error prints unique. Part #1 (diff) | |
| download | linux-dev-b26072276f20ce93717fdad5210e4ae9f1c944fa.tar.xz linux-dev-b26072276f20ce93717fdad5210e4ae9f1c944fa.zip | |
dmaengine: dw: Make error prints unique. Part #2
The same error message is printed from different switch cases. Since both of
these jump into same error label we can move error print there and add a DMA
direction in order to make it easier to grep error from sources.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/dw')
| -rw-r--r-- | drivers/dma/dw/core.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c index ac4fc0995a3e..a1c078d8cc85 100644 --- a/drivers/dma/dw/core.c +++ b/drivers/dma/dw/core.c @@ -815,11 +815,8 @@ dwc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, slave_sg_todev_fill_desc: desc = dwc_desc_get(dwc); - if (!desc) { - dev_err(chan2dev(chan), - "not enough descriptors available\n"); + if (!desc) goto err_desc_get; - } desc->lli.sar = mem; desc->lli.dar = reg; @@ -875,11 +872,8 @@ slave_sg_todev_fill_desc: slave_sg_fromdev_fill_desc: desc = dwc_desc_get(dwc); - if (!desc) { - dev_err(chan2dev(chan), - "not enough descriptors available\n"); + if (!desc) goto err_desc_get; - } desc->lli.sar = reg; desc->lli.dar = mem; @@ -923,6 +917,8 @@ slave_sg_fromdev_fill_desc: return &first->txd; err_desc_get: + dev_err(chan2dev(chan), + "not enough descriptors available. Direction %d\n", direction); dwc_desc_put(dwc, first); return NULL; } |