diff options
| author |   Dave Jiang <dave.jiang@intel.com> | 2021-04-07 12:59:47 -0700 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-04-12 14:45:50 +0530 |
| commit | 0fff71c5a311e1264988179f7dcc217fda15fadd (patch) | |
| tree | 8169ddb99d8208bd6567300b134b967674beaa0d /drivers/dma/idxd | |
| parent | dmaengine: idxd: fix opcap sysfs attribute output (diff) | |
| download | linux-dev-0fff71c5a311e1264988179f7dcc217fda15fadd.tar.xz linux-dev-0fff71c5a311e1264988179f7dcc217fda15fadd.zip | |
dmaengine: idxd: fix wq size store permission state
WQ size can only be changed when the device is disabled. Current code
allows change when device is enabled but wq is disabled. Change the check
to detect device state.
Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of driver")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/161782558755.107710.18138252584838406025.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/idxd')
| -rw-r--r-- | drivers/dma/idxd/sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c index c27ca01cf8b2..5f7bc4b1621a 100644 --- a/drivers/dma/idxd/sysfs.c +++ b/drivers/dma/idxd/sysfs.c @@ -989,7 +989,7 @@ static ssize_t wq_size_store(struct device *dev, if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags)) return -EPERM; - if (wq->state != IDXD_WQ_DISABLED) + if (idxd->state == IDXD_DEV_ENABLED) return -EPERM; if (size + total_claimed_wq_size(idxd) - wq->size > idxd->max_wq_size) |