diff options
| author |   Dave Jiang <dave.jiang@intel.com> | 2021-11-17 10:03:51 -0700 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-11-22 12:29:50 +0530 |
| commit | fa51b16d05583c7aebbc06330afb50276243d198 (patch) | |
| tree | 247e412a5eae041dfe58f412c6ddded7b2d11470 /drivers/dma/idxd | |
| parent | dmaengine: dw-edma: Fix return value check for dma_set_mask_and_coherent() (diff) | |
| download | linux-dev-fa51b16d05583c7aebbc06330afb50276243d198.tar.xz linux-dev-fa51b16d05583c7aebbc06330afb50276243d198.zip | |
dmaengine: idxd: fix calling wq quiesce inside spinlock
Dan reports that smatch has found idxd_wq_quiesce() is being called inside
the idxd->dev_lock. idxd_wq_quiesce() calls wait_for_completion() and
therefore it can sleep. Move the call outside of the spinlock as it does
not need device lock.
Fixes: 5b0c68c473a1 ("dmaengine: idxd: support reporting of halt interrupt")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163716858508.1721911.15051495873516709923.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/idxd')
| -rw-r--r-- | drivers/dma/idxd/irq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index 17f2f8a31b63..cf2c8bc4f147 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -137,10 +137,10 @@ halt: INIT_WORK(&idxd->work, idxd_device_reinit); queue_work(idxd->wq, &idxd->work); } else { - spin_lock(&idxd->dev_lock); idxd->state = IDXD_DEV_HALTED; idxd_wqs_quiesce(idxd); idxd_wqs_unmap_portal(idxd); + spin_lock(&idxd->dev_lock); idxd_device_clear_state(idxd); dev_err(&idxd->pdev->dev, "idxd halted, need %s.\n", |