diff options
| author |   Barry Song <song.bao.hua@hisilicon.com> | 2020-10-28 10:52:47 +1300 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2020-11-09 17:25:54 +0530 |
| commit | 280e7f90d4520682d0a18b33fa43fd8cccab3439 (patch) | |
| tree | eda903cca9706516a1e3de893df9d92859811318 /drivers/dma/milbeaut-xdmac.c | |
| parent | dmaengine: tegra210-adma: remove redundant irqsave and irqrestore in hardIRQ (diff) | |
| download | linux-dev-280e7f90d4520682d0a18b33fa43fd8cccab3439.tar.xz linux-dev-280e7f90d4520682d0a18b33fa43fd8cccab3439.zip | |
dmaengine: milbeaut-xdmac: remove redundant irqsave and irqrestore in hardIRQ
Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20201027215252.25820-6-song.bao.hua@hisilicon.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/milbeaut-xdmac.c')
| -rw-r--r-- | drivers/dma/milbeaut-xdmac.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/dma/milbeaut-xdmac.c b/drivers/dma/milbeaut-xdmac.c index 85a597228fb0..584c931e807a 100644 --- a/drivers/dma/milbeaut-xdmac.c +++ b/drivers/dma/milbeaut-xdmac.c @@ -160,10 +160,9 @@ static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id) { struct milbeaut_xdmac_chan *mc = dev_id; struct milbeaut_xdmac_desc *md; - unsigned long flags; u32 val; - spin_lock_irqsave(&mc->vc.lock, flags); + spin_lock(&mc->vc.lock); /* Ack and Stop */ val = FIELD_PREP(M10V_XDDSD_IS_MASK, 0x0); @@ -177,7 +176,7 @@ static irqreturn_t milbeaut_xdmac_interrupt(int irq, void *dev_id) milbeaut_xdmac_start(mc); out: - spin_unlock_irqrestore(&mc->vc.lock, flags); + spin_unlock(&mc->vc.lock); return IRQ_HANDLED; } |