diff options
| author |   Hanna Hawa <hannah@marvell.com> | 2018-07-17 13:30:00 +0300 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2018-07-20 15:01:58 +0530 |
| commit | 8bbafed8dd5cfa81071b50ead5cb60367fdef3a9 (patch) | |
| tree | bf7a0978409def77f35b298c2fd99f9eecb4ffbe /drivers/dma/mv_xor_v2.c | |
| parent | dmaengine: mv_xor_v2: explicitly freeup irq (diff) | |
| download | linux-dev-8bbafed8dd5cfa81071b50ead5cb60367fdef3a9.tar.xz linux-dev-8bbafed8dd5cfa81071b50ead5cb60367fdef3a9.zip | |
dmaengine: mv_xor_v2: kill the tasklets upon exit
The mv_xor_v2 driver uses a tasklet, initialized during the probe()
routine. However, it forgets to cleanup the tasklet using
tasklet_kill() function during the remove() routine, which this patch
fixes. This prevents the tasklet from potentially running after the
module has been removed.
Fixes: 19a340b1a820 ("dmaengine: mv_xor_v2: new driver")
Signed-off-by: Hanna Hawa <hannah@marvell.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/mv_xor_v2.c')
| -rw-r--r-- | drivers/dma/mv_xor_v2.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index e16083af9de9..e7184985b2a2 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -903,6 +903,8 @@ static int mv_xor_v2_remove(struct platform_device *pdev) platform_msi_domain_free_irqs(&pdev->dev); + tasklet_kill(&xor_dev->irq_tasklet); + clk_disable_unprepare(xor_dev->clk); return 0; |