diff options
| author |   Zou Wei <zou_wei@huawei.com> | 2021-05-31 14:36:03 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-06-03 16:37:37 +0530 |
| commit | dea8464ddf553803382efb753b6727dbf3931d06 (patch) | |
| tree | 2fd2d72d307fc82fb2d69c92a86913a5b66b6d46 /drivers/dma/sh | |
| parent | dmaengine: idxd: Fix missing error code in idxd_cdev_open() (diff) | |
| download | linux-dev-dea8464ddf553803382efb753b6727dbf3931d06.tar.xz linux-dev-dea8464ddf553803382efb753b6727dbf3931d06.zip | |
dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1622442963-54095-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/sh')
| -rw-r--r-- | drivers/dma/sh/rcar-dmac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index d530c1bf11d9..6885b3dcd7a9 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev) /* Enable runtime PM and initialize the device. */ pm_runtime_enable(&pdev->dev); - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret); return ret; |