diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2014-11-22 15:39:19 +0100 |
|---|---|---|
| committer |   Vinod Koul <vinod.koul@intel.com> | 2014-12-05 23:25:48 +0530 |
| commit | 39375334a1c18f63faefeebea74363a705b87f0a (patch) | |
| tree | cf4d75c3c2d5ccf12a05b00690f425be16a02fee /drivers/dma/ste_dma40.c | |
| parent | dma: imx-sdma: clarify about firmware not found error (diff) | |
| download | linux-dev-39375334a1c18f63faefeebea74363a705b87f0a.tar.xz linux-dev-39375334a1c18f63faefeebea74363a705b87f0a.zip | |
dmaengine: ste_dma40: fix error return code
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/ste_dma40.c')
| -rw-r--r-- | drivers/dma/ste_dma40.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 5fe59335e247..d2d084110d12 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3432,6 +3432,7 @@ static int __init d40_lcla_allocate(struct d40_base *base) d40_err(base->dev, "Failed to allocate %d pages.\n", base->lcla_pool.pages); + ret = -ENOMEM; for (j = 0; j < i; j++) free_pages(page_list[j], base->lcla_pool.pages); |