diff options
| author |   Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> | 2019-10-15 20:18:18 +0530 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2019-10-20 19:35:26 +0530 |
| commit | 005a017926ffe648b38b6462748a74c850a31e62 (patch) | |
| tree | 75c536fdef2121300a59bcd556590431d4891586 /drivers/dma | |
| parent | dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms (diff) | |
| download | linux-dev-005a017926ffe648b38b6462748a74c850a31e62.tar.xz linux-dev-005a017926ffe648b38b6462748a74c850a31e62.zip | |
dmaengine: xilinx_dma: Remove desc_callback_valid check
In descriptor cleanup the call to desc_callback_valid can be safely
removed as both callback pointers i.e callback_result and callback
are anyway checked in invoke(). There is no much benefit in having
redundant checks.
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Nicholas Graumann <nick.graumann@gmail.com>
Reviewed-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Link: https://lore.kernel.org/r/1571150904-3988-2-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/xilinx/xilinx_dma.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 94cdc410977b..3e690ec45c13 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -832,11 +832,9 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan) /* Run the link descriptor callback function */ dmaengine_desc_get_callback(&desc->async_tx, &cb); - if (dmaengine_desc_callback_valid(&cb)) { - spin_unlock_irqrestore(&chan->lock, flags); - dmaengine_desc_callback_invoke(&cb, NULL); - spin_lock_irqsave(&chan->lock, flags); - } + spin_unlock_irqrestore(&chan->lock, flags); + dmaengine_desc_callback_invoke(&cb, NULL); + spin_lock_irqsave(&chan->lock, flags); /* Run any dependencies, then free the descriptor */ dma_run_dependencies(&desc->async_tx); |