diff options
| author |   Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-16 01:48:55 -0500 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2019-08-20 17:16:15 +0530 |
| commit | 2c231c0c1dec42192aca0f87f2dc68b8f0cbc7d2 (patch) | |
| tree | 688353738a6905985bd28aa5f56f675eaf52d62e /drivers/dma | |
| parent | Linux 5.3-rc5 (diff) | |
| download | linux-dev-2c231c0c1dec42192aca0f87f2dc68b8f0cbc7d2.tar.xz linux-dev-2c231c0c1dec42192aca0f87f2dc68b8f0cbc7d2.zip | |
dmaengine: ti: dma-crossbar: Fix a memory leak bug
In ti_dra7_xbar_probe(), 'rsv_events' is allocated through kcalloc(). Then
of_property_read_u32_array() is invoked to search for the property.
However, if this process fails, 'rsv_events' is not deallocated, leading to
a memory leak bug. To fix this issue, free 'rsv_events' before returning
the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938136-7249-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ti/dma-crossbar.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c index ad2f0a4cd6a4..f255056696ee 100644 --- a/drivers/dma/ti/dma-crossbar.c +++ b/drivers/dma/ti/dma-crossbar.c @@ -391,8 +391,10 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev) ret = of_property_read_u32_array(node, pname, (u32 *)rsv_events, nelm * 2); - if (ret) + if (ret) { + kfree(rsv_events); return ret; + } for (i = 0; i < nelm; i++) { ti_dra7_xbar_reserve(rsv_events[i][0], rsv_events[i][1], |