diff options
| author |   Minghao Chi <chi.minghao@zte.com.cn> | 2022-05-16 11:54:12 +0000 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-05-16 23:19:43 +0530 |
| commit | 411dccf9d271e49f37471c73ebedb18719d6b608 (patch) | |
| tree | 2e8a25cb790473b9323a04eb8f549fee8d430652 /drivers/dma | |
| parent | dmaengine: idxd: add missing callback function to support DMA_INTERRUPT (diff) | |
| download | linux-dev-411dccf9d271e49f37471c73ebedb18719d6b608.tar.xz linux-dev-411dccf9d271e49f37471c73ebedb18719d6b608.zip | |
dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516115412.1651772-1-chi.minghao@zte.com.cn
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/idxd/device.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 8b1f8591ae83..1143886f4a80 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -1179,7 +1179,6 @@ void idxd_wq_free_irq(struct idxd_wq *wq) if (wq->type != IDXD_WQT_KERNEL) return; - synchronize_irq(ie->vector); free_irq(ie->vector, ie); idxd_flush_pending_descs(ie); if (idxd->request_int_handles) |