diff options
| author |   Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> | 2022-05-10 12:42:42 +0530 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-05-16 18:21:47 +0530 |
| commit | 517a710ac8fe9cbc48d0ec3ca81377f6ef3b86b7 (patch) | |
| tree | 5d95adb364e077e8665f86cb10c1f307817b5ddd /drivers/dma | |
| parent | dmaengine: zynqmp_dma: check dma_async_device_register return value (diff) | |
| download | linux-dev-517a710ac8fe9cbc48d0ec3ca81377f6ef3b86b7.tar.xz linux-dev-517a710ac8fe9cbc48d0ec3ca81377f6ef3b86b7.zip | |
dmaengine: zynqmp_dma: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
pm_runtime_resume_and_get() automatically handle dev->power.usage_count
decrement on errors, so prefer using it and also implement it's error
handling.
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1652166762-18317-4-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/xilinx/zynqmp_dma.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 915dbe6275d4..dc299ab36818 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -1078,7 +1078,11 @@ static int zynqmp_dma_probe(struct platform_device *pdev) pm_runtime_set_autosuspend_delay(zdev->dev, ZDMA_PM_TIMEOUT); pm_runtime_use_autosuspend(zdev->dev); pm_runtime_enable(zdev->dev); - pm_runtime_get_sync(zdev->dev); + ret = pm_runtime_resume_and_get(zdev->dev); + if (ret < 0) { + dev_err(&pdev->dev, "device wakeup failed.\n"); + pm_runtime_disable(zdev->dev); + } if (!pm_runtime_enabled(zdev->dev)) { ret = zynqmp_dma_runtime_resume(zdev->dev); if (ret) |