diff options
| author |   Xin Xiong <xiongx18@fudan.edu.cn> | 2021-09-11 15:05:33 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2021-10-25 12:12:58 +0530 |
| commit | 9bf9e0b44104d05b21761441227ae566c732ecb9 (patch) | |
| tree | ac4976190f60876ef9b7080171922d748fd4182e /drivers/dma | |
| parent | dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic (diff) | |
| download | linux-dev-9bf9e0b44104d05b21761441227ae566c732ecb9.tar.xz linux-dev-9bf9e0b44104d05b21761441227ae566c732ecb9.zip | |
dmaengine: mmp_pdma: fix reference count leaks in mmp_pdma_probe
The issue happens in an error handling path. If
of_dma_controller_register() fails, the function simply prints error
messages and returns error code, without decrementing the reference
count of pdev->device incremented earlier by
dma_async_device_register(), which may result in refcount leaks.
Fix it by invoking dma_async_device_unregister() before returning the
error code.
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Link: https://lore.kernel.org/r/20210911070533.3114-1-xiongx18@fudan.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/mmp_pdma.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 89f1814ff27a..a23563cd118b 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -1123,6 +1123,7 @@ static int mmp_pdma_probe(struct platform_device *op) mmp_pdma_dma_xlate, pdev); if (ret < 0) { dev_err(&op->dev, "of_dma_controller_register failed\n"); + dma_async_device_unregister(&pdev->device); return ret; } } |