aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/dma
diff options
context:
space:
mode:
authorPetr Kulhavy <petr@barix.com>2015-03-23 21:35:01 +0100
committerVinod Koul <vinod.koul@intel.com>2015-04-01 09:15:57 +0530
commitab7add30ce63a7147f045f00c65a44c0f14ad6b2 (patch)
tree45f8d52a4256b0e1333b301645834bbc37be0626 /drivers/dma
parentdmaengine: ste_dma40: fix implicit conversion (diff)
downloadlinux-dev-ab7add30ce63a7147f045f00c65a44c0f14ad6b2.tar.xz
linux-dev-ab7add30ce63a7147f045f00c65a44c0f14ad6b2.zip
dmaengine: edma: fixed wrongly initialized data parameter to the edma callback
The "data" parameter passed indirectly to the edma_callback() should be edma_chan and not the dma_chan. This bug was so far harmless since the offset of struct dma_chan within struct edma_chan is 0. However as soon as someone changes struct edma_chan this would cause troubles. Signed-off-by: Petr Kulhavy <petr@barix.com> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r--drivers/dma/edma.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 276157f22612..0ea813d98998 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -805,7 +805,7 @@ static int edma_alloc_chan_resources(struct dma_chan *chan)
LIST_HEAD(descs);
a_ch_num = edma_alloc_channel(echan->ch_num, edma_callback,
- chan, EVENTQ_DEFAULT);
+ echan, EVENTQ_DEFAULT);
if (a_ch_num < 0) {
ret = -ENODEV;