diff options
| author |   Pan Bian <bianpan2016@163.com> | 2016-12-02 22:49:01 +0800 |
|---|---|---|
| committer |   Vinod Koul <vinod.koul@intel.com> | 2016-12-06 10:28:11 +0530 |
| commit | b424d2a0a186e7fe4b70db1d616a39d4c3fefd31 (patch) | |
| tree | 316baa292faef4e988c7491f1f401011ee6c06d5 /drivers/dma | |
| parent | dmaengine: ioatdma: error string table missing an entry (diff) | |
| download | linux-dev-b424d2a0a186e7fe4b70db1d616a39d4c3fefd31.tar.xz linux-dev-b424d2a0a186e7fe4b70db1d616a39d4c3fefd31.zip | |
dmaengine: ioat: set error code on failures
In function ioat_dma_self_test(), when the calls to dma_mapping_error()
fails, the value of return variable err is 0 (indicates no error). As a
result, the return value may be inconsistent with the execution status.
This patch fixes the bug by assigning -ENOMEM to err on the error path.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ioat/init.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 015f7110b96d..32383ef524c4 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -340,11 +340,13 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma) dma_src = dma_map_single(dev, src, IOAT_TEST_SIZE, DMA_TO_DEVICE); if (dma_mapping_error(dev, dma_src)) { dev_err(dev, "mapping src buffer failed\n"); + err = -ENOMEM; goto free_resources; } dma_dest = dma_map_single(dev, dest, IOAT_TEST_SIZE, DMA_FROM_DEVICE); if (dma_mapping_error(dev, dma_dest)) { dev_err(dev, "mapping dest buffer failed\n"); + err = -ENOMEM; goto unmap_src; } flags = DMA_PREP_INTERRUPT; |