diff options
| author |   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2018-07-03 00:29:29 +0000 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2018-07-09 22:22:32 +0530 |
| commit | e919417bd6468b7f1b2899200a78f1ad078757d3 (patch) | |
| tree | e2c2d62ca4cd31bbe5031d798f88a4abebf4117d /drivers/dma | |
| parent | dmaengine: rcar-dmac: Disable interrupts while stopping channels (diff) | |
| download | linux-dev-e919417bd6468b7f1b2899200a78f1ad078757d3.tar.xz linux-dev-e919417bd6468b7f1b2899200a78f1ad078757d3.zip | |
dmaengine: rcar-dmac: clear channel register when error
We need to clear channel register in error case as recovery.
The channel is already stopped in such case, thus we don't need to call
rcar_dmac_chan_halt() before clearing.
rcar_dmac_chan_halt() will clear and confirm DE bit.
But it will be failed because channel is already stopped in error case.
In other words, we shouldn't call it then.
Reported-by: Hiroki Negishi <hiroki.negishi.bx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Hiroki Negishi <hiroki.negishi.bx@renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/sh/rcar-dmac.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index af2f2639cec9..9dc73ac92359 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -1522,7 +1522,15 @@ static irqreturn_t rcar_dmac_isr_channel(int irq, void *dev) chcr = rcar_dmac_chan_read(chan, RCAR_DMACHCR); if (chcr & RCAR_DMACHCR_CAE) { - rcar_dmac_chan_halt(chan); + struct rcar_dmac *dmac = to_rcar_dmac(chan->chan.device); + + /* + * We don't need to call rcar_dmac_chan_halt() + * because channel is already stopped in error case. + * We need to clear register and check DE bit as recovery. + */ + rcar_dmac_write(dmac, RCAR_DMACHCLR, 1 << chan->index); + rcar_dmac_chcr_de_barrier(chan); reinit = true; goto spin_lock_end; } |