diff options
| author |   Pan Bian <bianpan2016@163.com> | 2016-12-04 14:07:18 +0800 |
|---|---|---|
| committer |   Borislav Petkov <bp@suse.de> | 2016-12-04 10:51:42 +0100 |
| commit | 0de2788447b67891a31a156c0206fd159e4a8981 (patch) | |
| tree | 98d278ca0d5ac41f73fa13f2046547e551ba8f87 /drivers/edac/amd64_edac.c | |
| parent | EDAC, amd64: Improve amd64-specific printing macros (diff) | |
| download | linux-dev-0de2788447b67891a31a156c0206fd159e4a8981.tar.xz linux-dev-0de2788447b67891a31a156c0206fd159e4a8981.zip | |
EDAC, amd64: Fix improper return value
When the call to zalloc_cpumask_var() fails, returning "false" seems
improper. The real value of macro "false" is 0, and 0 means no error.
Return -ENOMEM instead.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071
Signed-off-by: Pan Bian <bianpan2016@163.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1480831638-5361-1-git-send-email-bianpan201604@163.com
Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac/amd64_edac.c')
| -rw-r--r-- | drivers/edac/amd64_edac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 9a7cf3c8df06..260251177830 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2913,7 +2913,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on) if (!zalloc_cpumask_var(&cmask, GFP_KERNEL)) { amd64_warn("%s: error allocating mask\n", __func__); - return false; + return -ENOMEM; } get_cpus_on_this_dct_cpumask(cmask, nid); |