diff options
| author |   Borislav Petkov <borislav.petkov@amd.com> | 2009-09-18 12:27:27 +0200 |
|---|---|---|
| committer | Borislav Petkov <borislav.petkov@amd.com> | 2009-10-07 16:48:08 +0200 |
| commit | 72f158fe6fc2033ceb0f3e0e9e5c2aa356fed6da (patch) | |
| tree | 96cbbab93865d2afd42688ba83a0f1b21c98a7d1 /drivers/edac | |
| parent | amd64_edac: fix DRAM base and limit address extraction (diff) | |
| download | linux-dev-72f158fe6fc2033ceb0f3e0e9e5c2aa356fed6da.tar.xz linux-dev-72f158fe6fc2033ceb0f3e0e9e5c2aa356fed6da.zip | |
amd64_edac: fix interleave enable tests
The pvt->dram_IntlvEn saves the 3 "Interleave Enable" bits already
right-shifted by 8 so the check in find_mc_by_sys_addr() by shifting the
values to the left 8 bits is wrong.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/amd64_edac.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 6e2ccce225db..854c7c125035 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -289,12 +289,12 @@ static struct mem_ctl_info *find_mc_by_sys_addr(struct mem_ctl_info *mci, goto found; } - if (unlikely((intlv_en != (0x01 << 8)) && - (intlv_en != (0x03 << 8)) && - (intlv_en != (0x07 << 8)))) { + if (unlikely((intlv_en != 0x01) && + (intlv_en != 0x03) && + (intlv_en != 0x07))) { amd64_printk(KERN_WARNING, "junk value of 0x%x extracted from " "IntlvEn field of DRAM Base Register for node 0: " - "This probably indicates a BIOS bug.\n", intlv_en); + "this probably indicates a BIOS bug.\n", intlv_en); return NULL; } |