aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorAndrzej Hajda <a.hajda@samsung.com>2015-12-14 11:06:03 +0100
committerChanwoo Choi <cw00.choi@samsung.com>2015-12-15 10:02:34 +0900
commitc05c0d544edfb0ffbbd01acd199ea9626bdfd6c3 (patch)
tree226aa847d2f04d5784ffb038a4d89299e4250adb /drivers/extcon
parentextcon: max77693: fix handling return value of regmap_irq_get_virq (diff)
downloadlinux-dev-c05c0d544edfb0ffbbd01acd199ea9626bdfd6c3.tar.xz
linux-dev-c05c0d544edfb0ffbbd01acd199ea9626bdfd6c3.zip
extcon: max77843: fix handling return value of regmap_irq_get_virq
The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon-max77843.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 9f9ea334399c..74dfb7f4f277 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -811,7 +811,7 @@ static int max77843_muic_probe(struct platform_device *pdev)
for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
- unsigned int virq = 0;
+ int virq = 0;
virq = regmap_irq_get_virq(max77843->irq_data_muic,
muic_irq->irq);