aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorDinghao Liu <dinghao.liu@zju.edu.cn>2021-01-19 16:10:55 +0800
committerChanwoo Choi <cw00.choi@samsung.com>2021-03-15 11:09:38 +0900
commitd3bdd1c3140724967ca4136755538fa7c05c2b4e (patch)
tree40c9ad7dc5db19f34c748212db44a9af3bef8c41 /drivers/extcon
parentextcon: Add stubs for extcon_register_notifier_all() functions (diff)
downloadlinux-dev-d3bdd1c3140724967ca4136755538fa7c05c2b4e.tar.xz
linux-dev-d3bdd1c3140724967ca4136755538fa7c05c2b4e.zip
extcon: Fix error handling in extcon_dev_register
When devm_kcalloc() fails, we should execute device_unregister() to unregister edev->dev from system. Fixes: 046050f6e623e ("extcon: Update the prototype of extcon_register_notifier() with enum extcon") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 0a6438cbb3f3..e7a9561a826d 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1241,6 +1241,7 @@ int extcon_dev_register(struct extcon_dev *edev)
sizeof(*edev->nh), GFP_KERNEL);
if (!edev->nh) {
ret = -ENOMEM;
+ device_unregister(&edev->dev);
goto err_dev;
}