net: genl: fix error path memory leak in policy dumping - linux-dev - Linux kernel development work

diff options

author	Jakub Kicinski <kuba@kernel.org>	2022-08-16 09:19:39 -0700
committer	Jakub Kicinski <kuba@kernel.org>	2022-08-18 10:20:48 -0700
commit	249801360db3dec4f73768c502192020bfddeacc (patch)
tree	12f45371df138671e0ef5f3f6b0fdb3692b4dbe2 /drivers/fc4/ssh:
parent	stmmac: intel: Add a missing clk_disable_unprepare() call in intel_eth_pci_remove() (diff)

net: genl: fix error path memory leak in policy dumping

If construction of the array of policies fails when recording non-first policy we need to unwind. netlink_policy_dump_add_policy() itself also needs fixing as it currently gives up on error without recording the allocated pointer in the pstate pointer. Reported-by: syzbot+dc54d9ba8153b216cae0@syzkaller.appspotmail.com Fixes: 50a896cf2d6f ("genetlink: properly support per-op policy dumping") Link: https://lore.kernel.org/r/20220816161939.577583-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Diffstat (limited to 'drivers/fc4/ssh:')

0 files changed, 0 insertions, 0 deletions

/* * LEDs driver for the "User LED" on Routerboard532 * * Copyright (C) 2009 Phil Sutter <n0-1@freewrt.org> * * Based on leds-cobalt-qube.c by Florian Fainelly and * rb-diag.c (my own standalone driver for both LED and * button of Routerboard532). */ #include <linux/leds.h> #include <linux/module.h> #include <linux/platform_device.h> #include <asm/mach-rc32434/gpio.h> #include <asm/mach-rc32434/rb.h> static void rb532_led_set(struct led_classdev *cdev, enum led_brightness brightness) { if (brightness) set_latch_u5(LO_ULED, 0); else set_latch_u5(0, LO_ULED); } static enum led_brightness rb532_led_get(struct led_classdev *cdev) { return (get_latch_u5() & LO_ULED) ? LED_FULL : LED_OFF; } static struct led_classdev rb532_uled = { .name = "uled", .brightness_set = rb532_led_set, .brightness_get = rb532_led_get, .default_trigger = "nand-disk", }; static int rb532_led_probe(struct platform_device *pdev) { return led_classdev_register(&pdev->dev, &rb532_uled); } static int rb532_led_remove(struct platform_device *pdev) { led_classdev_unregister(&rb532_uled); return 0; } static struct platform_driver rb532_led_driver = { .probe = rb532_led_probe, .remove = rb532_led_remove, .driver = { .name = "rb532-led", }, }; module_platform_driver(rb532_led_driver); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("User LED support for Routerboard532"); MODULE_AUTHOR("Phil Sutter <n0-1@freewrt.org>"); MODULE_ALIAS("platform:rb532-led");


context:
space:
mode: