diff options
| author |   Geliang Tang <geliangtang@gmail.com> | 2017-06-02 13:52:05 +0000 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2017-06-05 17:50:42 +0200 |
| commit | 5f72cad65cfaac5e40d0de8b7f48ee647af69cd5 (patch) | |
| tree | 372d88d129d9bff7eba39bb5dfa5746c78bd7cda /drivers/firmware/efi/test/efi_test.c | |
| parent | efi/capsule: Add support for Quark security header (diff) | |
| download | linux-dev-5f72cad65cfaac5e40d0de8b7f48ee647af69cd5.tar.xz linux-dev-5f72cad65cfaac5e40d0de8b7f48ee647af69cd5.zip | |
efi/efi_test: Use memdup_user() helper
Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Ivan Hu <ivan.hu@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20170602135207.21708-12-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware/efi/test/efi_test.c')
| -rw-r--r-- | drivers/firmware/efi/test/efi_test.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c index 8cd578f62059..08129b7b80ab 100644 --- a/drivers/firmware/efi/test/efi_test.c +++ b/drivers/firmware/efi/test/efi_test.c @@ -71,18 +71,13 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src, if (!access_ok(VERIFY_READ, src, 1)) return -EFAULT; - buf = kmalloc(len, GFP_KERNEL); - if (!buf) { + buf = memdup_user(src, len); + if (IS_ERR(buf)) { *dst = NULL; - return -ENOMEM; + return PTR_ERR(buf); } *dst = buf; - if (copy_from_user(*dst, src, len)) { - kfree(buf); - return -EFAULT; - } - return 0; } |