diff options
| author |   Marc-André Lureau <marcandre.lureau@redhat.com> | 2018-02-28 16:06:07 +0100 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2018-03-20 03:17:38 +0200 |
| commit | f295c8dba71841f007e2154143109d1517670a08 (patch) | |
| tree | 86e6993d59f2067799588dcca915c08858d27136 /drivers/firmware/qemu_fw_cfg.c | |
| parent | fw_cfg: fix sparse warnings with fw_cfg_file (diff) | |
| download | linux-dev-f295c8dba71841f007e2154143109d1517670a08.tar.xz linux-dev-f295c8dba71841f007e2154143109d1517670a08.zip | |
fw_cfg: fix sparse warning reading FW_CFG_ID
Use a restricted type for reading FW_CFG_ID, fixing sparse warning:
drivers/firmware/qemu_fw_cfg.c:540:22: warning: cast to restricted __le32
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/firmware/qemu_fw_cfg.c')
| -rw-r--r-- | drivers/firmware/qemu_fw_cfg.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 7978844f6b37..0eb155fdfb35 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -530,6 +530,7 @@ static inline void fw_cfg_kobj_cleanup(struct kobject *kobj) static int fw_cfg_sysfs_probe(struct platform_device *pdev) { int err; + __le32 rev; /* NOTE: If we supported multiple fw_cfg devices, we'd first create * a subdirectory named after e.g. pdev->id, then hang per-device @@ -555,8 +556,8 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev) goto err_probe; /* get revision number, add matching top-level attribute */ - fw_cfg_read_blob(FW_CFG_ID, &fw_cfg_rev, 0, sizeof(fw_cfg_rev)); - fw_cfg_rev = le32_to_cpu(fw_cfg_rev); + fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev)); + fw_cfg_rev = le32_to_cpu(rev); err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr); if (err) goto err_rev; |