diff options
| author |   Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2017-05-23 17:07:42 -0700 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-25 15:41:20 +0200 |
| commit | 3eec6a1c0cf31b982cad560c16e19fdb1851ae91 (patch) | |
| tree | 371affc308bfd41990b2e5e6203093ac6f58876e /drivers/firmware | |
| parent | firmware: google: memconsole: Prevent overrun attack on coreboot console (diff) | |
| download | linux-dev-3eec6a1c0cf31b982cad560c16e19fdb1851ae91.tar.xz linux-dev-3eec6a1c0cf31b982cad560c16e19fdb1851ae91.zip | |
firmware: vpd: use kdtrndup when copying section key
Instead of open-coding kstrndup with kzalloc + memcpy, let's use
the helper.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/google/vpd.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index 1e7860f02f4f..8bd51eaededd 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -118,14 +118,13 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len, info = kzalloc(sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; - info->key = kzalloc(key_len + 1, GFP_KERNEL); + + info->key = kstrndup(key, key_len, GFP_KERNEL); if (!info->key) { ret = -ENOMEM; goto free_info; } - memcpy(info->key, key, key_len); - sysfs_bin_attr_init(&info->bin_attr); info->bin_attr.attr.name = info->key; info->bin_attr.attr.mode = 0444; |