diff options
| author |   Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-11-15 16:33:10 -0600 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-11-28 16:31:27 +0100 |
| commit | 5f76c6f313bffbf372c0722582e7bd509f0d3510 (patch) | |
| tree | e5875a108f5d862301b317ccde0ec0ced6b7a0ad /drivers/fpga/fpga-mgr.c | |
| parent | fpga: add attribute groups (diff) | |
| download | linux-dev-5f76c6f313bffbf372c0722582e7bd509f0d3510.tar.xz linux-dev-5f76c6f313bffbf372c0722582e7bd509f0d3510.zip | |
fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get
Notice that mgr = to_fpga_manager(dev); expands to:
mgr = container_of(dev, struct fpga_manager, dev);
and container_of is never null, so this null check is
unnecessary.
Addresses-Coverity-ID: 1397916
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/fpga/fpga-mgr.c')
| -rw-r--r-- | drivers/fpga/fpga-mgr.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index 223f2401939b..9939d2cbc9a6 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -412,8 +412,6 @@ static struct fpga_manager *__fpga_mgr_get(struct device *dev) struct fpga_manager *mgr; mgr = to_fpga_manager(dev); - if (!mgr) - goto err_dev; if (!try_module_get(dev->parent->driver->owner)) goto err_dev; |