diff options
| author |   Yunjian Wang <wangyunjian@huawei.com> | 2021-06-04 19:03:18 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-04 14:44:18 -0700 |
| commit | 944d671d5faa0d78980a3da5c0f04960ef1ad893 (patch) | |
| tree | 61215bceb853496d1e709ad7a4ad2658878d51f6 /drivers/fpga/fpga-mgr.c | |
| parent | Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue (diff) | |
| download | linux-dev-944d671d5faa0d78980a3da5c0f04960ef1ad893.tar.xz linux-dev-944d671d5faa0d78980a3da5c0f04960ef1ad893.zip | |
sch_htb: fix refcount leak in htb_parent_to_leaf_offload
The commit ae81feb7338c ("sch_htb: fix null pointer dereference
on a null new_q") fixes a NULL pointer dereference bug, but it
is not correct.
Because htb_graft_helper properly handles the case when new_q
is NULL, and after the previous patch by skipping this call
which creates an inconsistency : dev_queue->qdisc will still
point to the old qdisc, but cl->parent->leaf.q will point to
the new one (which will be noop_qdisc, because new_q was NULL).
The code is based on an assumption that these two pointers are
the same, so it can lead to refcount leaks.
The correct fix is to add a NULL pointer check to protect
qdisc_refcount_inc inside htb_parent_to_leaf_offload.
Fixes: ae81feb7338c ("sch_htb: fix null pointer dereference on a null new_q")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Suggested-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/fpga/fpga-mgr.c')
0 files changed, 0 insertions, 0 deletions