diff options
| author |   Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2021-08-13 14:40:42 +0800 |
|---|---|---|
| committer |   Moritz Fischer <mdf@kernel.org> | 2021-09-15 14:01:24 -0700 |
| commit | a1e4470823d99e75b596748086e120dea169ed3c (patch) | |
| tree | 32b78abf11f0a504106bf0f21c0e799aba827fea /drivers/fpga | |
| parent | fpga: machxo2-spi: Return an error on failure (diff) | |
| download | linux-dev-a1e4470823d99e75b596748086e120dea169ed3c.tar.xz linux-dev-a1e4470823d99e75b596748086e120dea169ed3c.zip | |
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.
Eliminate the follow smatch warning:
drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
warn: missing error code 'ret'.
[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Diffstat (limited to 'drivers/fpga')
| -rw-r--r-- | drivers/fpga/machxo2-spi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b4a530a31302..ea2ec3c6815c 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -338,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr, break; if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) { machxo2_cleanup(mgr); + ret = -EINVAL; goto fail; } } while (1); |